Refactor FiltersDecoder with Map-based parsing#223
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the FiltersDecoder to improve its JSON parsing approach by replacing Jackson JsonNode field iteration with a Map-based TypeReference approach, and adds comprehensive test coverage for multi-filter scenarios.
- Replaces field iteration approach with Map-based parsing using TypeReference
- Adds test coverage for decoding JSON with multiple filter types (ids, kinds, since)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FiltersDecoder.java | Refactors JSON parsing from JsonNode field iteration to Map-based approach with TypeReference |
| FiltersDecoderTest.java | Adds unit test for multiple filter types to validate decoder functionality |
Comments suppressed due to low confidence (1)
nostr-java-event/src/test/java/nostr/event/unit/FiltersDecoderTest.java:384
- Using
Instant.now()creates a non-deterministic test that could fail due to timing. Consider using a fixed timestamp likeInstant.parse("2023-01-01T00:00:00Z").toEpochMilli()for more reliable testing.
Long since = Date.from(Instant.now()).getTime();
| package nostr.event.json.codec; | ||
|
|
||
| import com.fasterxml.jackson.core.type.TypeReference; | ||
| import com.fasterxml.jackson.databind.JsonNode; |
There was a problem hiding this comment.
The JsonNode import is now unused after the refactor. Consider removing this import to keep the code clean.
tcheeric
deleted the
codex/refactor-filtersdecoder-to-use-mapper_afterburner
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FiltersDecoderto parse filters using TypeReference Map instead of JsonNode iterationTesting
mvn verify -DskipTestshttps://chatgpt.com/codex/tasks/task_b_6889085c8350833193e92decedf6ccf5